-
Notifications
You must be signed in to change notification settings - Fork 513
Expose more battery and power connection state #2226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slime73
requested changes
Sep 30, 2025
Thanks for the review @slime73 ! Appreciate it. I believe it's all resolved now. |
slime73
requested changes
Oct 13, 2025
Thanks, those were some obvious ones. I initialize the state now in both functions which makes it a bit simpler. |
slime73
approved these changes
Oct 17, 2025
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull implements the api to call the following:
https://wiki.libsdl.org/SDL3/SDL_GetJoystickPowerInfo
https://wiki.libsdl.org/SDL3/SDL_GetJoystickConnectionState
https://wiki.libsdl.org/SDL3/SDL_GetGamepadPowerInfo
https://wiki.libsdl.org/SDL3/SDL_GetGamepadConnectionState
It's worth noting though, the battery info returned from PowerInfo they have on the wiki:
You should never take a battery status as absolute truth. Batteries (especially failing batteries) are delicate hardware, and the values reported here are best estimates based on what that hardware reports. It's not uncommon for older batteries to lose stored power much faster than it reports, or completely drain when reporting it has 20 percent left, etc.
I found this in testing, I tried a wireless steam controller on battery and it did not report any battery percent. Other controllers may though. Even when using the SDL testcontroller it did not report anything.
Testing wired though with the following script works as expected
I suspect this somewhat resolves #2223